[PATCH libvirt-dbus v3 1/3] src: fix double free of virDomain object

The virDomainSnapshotGetDomain() method does NOT increment the refcount on the returned virDomain, so it must not be unrefed. This double free is responsible for random failures of the test_snapshot.py tests. Reviewed-by: Andrea Bolognani <abologna(a)redhat.com&gt; Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com&gt; --- src/domainsnapshot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/domainsnapshot.c b/src/domainsnapshot.c index f3571a1..78a9f9a 100644 --- a/src/domainsnapshot.c +++ b/src/domainsnapshot.c @@ -63,7 +63,7 @@ virtDBusDomainSnapshotGetParent(GVariant *inArgs, g_autoptr(virDomainSnapshot) domainSnapshot = NULL; g_autoptr(virDomainSnapshot) parent = NULL; guint flags; - g_autoptr(virDomain) domain = NULL; + virDomainPtr domain = NULL; g_autofree gchar *parentPath = NULL; g_variant_get(inArgs, "(u)", &flags); @@ -159,7 +159,7 @@ virtDBusDomainSnapshotListAllChildren(GVariant *inArgs, guint flags; GVariantBuilder builder; GVariant *gdomainSnapshots; - g_autoptr(virDomain) domain = NULL; + virDomainPtr domain = NULL; g_variant_get(inArgs, "(u)", &flags); -- 2.26.2