Re: [libvirt] [PATCH v5 0/8] perf: add more perf events support
On 08/29/2016 10:00 PM, Ren, Qiaowei wrote:
Hi John,
How about this patch series?
I made adjustments to your series, but I also made tweaks and those
needed to be OK'd/checked by someone such as you.... Go back to the v4
series and read my comment. In particular from review of patch 2 and
more specifically code flow changes w/r/t the initialization which now
mostly become patch 7.
So please go through the series, make sure it "works" as you expect and
let me know. Once that's done and 2.2 is released, I can push these. If
tweaks need to be made, then we can do so.
Thanks,
Qiaowei
> -----Original Message-----
> From: John Ferlan [mailto:jferlan@redhat.com]
> Sent: Thursday, August 4, 2016 6:31 AM
> To: libvir-list(a)redhat.com
> Cc: Ren, Qiaowei <qiaowei.ren(a)intel.com>
> Subject: [PATCH v5 0/8] perf: add more perf events support
>
> v4: http://www.redhat.com/archives/libvir-list/2016-July/msg00607.html
>
> Reworked/reworded the series slightly. The end result is mostly the same as the
> original, but with the suggested tweaks.
>
>
> John Ferlan (3):
> virsh: Add a forward reference to perf command from domstats --perf
> virsh: Rework the perf event names into a table.
> util: Move virPerfNew and virPerfFree
>
> Qiaowei Ren (5):
> perf: rename qemuDomainGetStatsPerfRdt()
> perf: Remove the switch from qemuDomainGetStatsPerf
> util: Add some comment details for virPerfEventType
> perf: Adjust the perf initialization
> perf: add more perf events support
>
> docs/formatdomain.html.in | 24 +++
> docs/schemas/domaincommon.rng | 4 +
> include/libvirt/libvirt-domain.h | 39 +++++
> src/libvirt-domain.c | 9 ++
> src/qemu/qemu_driver.c | 23 ++-
> src/util/virperf.c | 230 +++++++++++++++++-----------
> src/util/virperf.h | 14 +-
> tests/genericxml2xmlindata/generic-perf.xml | 4 +
> tools/virsh.pod | 40 +++--
> 9 files changed, 275 insertions(+), 112 deletions(-)
>
> --
> 2.7.4