Re: [libvirt] [PATCH 1/7] Revert "virnetsocket: Provide socket address format in a more standard form"

On 06/20/2016 10:27 AM, Ján Tomko wrote: > This partially reverts commit 9b45c9f049a7e9b6c1abfa6988b63b760714e169. > > It changed the default format of socket address from the one SASL > requires, but did not adjust all the callers. > > It also removed the test coverage for it. > > Revert most of the changes except the virSocketAddrFormatFull support > for URI-formatted strings. > > This fixes https://bugzilla.redhat.com/show_bug.cgi?id=1345743 while > reverting the format used by virt-admin's client-info command from > the URI one to the SASL one. > > https://bugzilla.redhat.com/show_bug.cgi?id=1345743 > --- > daemon/remote.c | 13 ++----------- > src/remote/remote_driver.c | 7 ------- > src/rpc/virnetclient.c | 10 ---------- > src/rpc/virnetclient.h | 2 -- > src/rpc/virnetserverclient.c | 13 ------------- > src/rpc/virnetserverclient.h | 2 -- > src/rpc/virnetsocket.c | 17 ++--------------- > src/rpc/virnetsocket.h | 2 -- > tests/virnetsockettest.c | 10 +++++----- > 9 files changed, 9 insertions(+), 67 deletions(-) > So prior to Erik's changes, we provided/used SASL addresses. Erik's change was to provide/use URI addresses. Can I assume the "missed" change was perhaps in remoteAuthSASL where localAddr/remoteAddr weren't used?