Re: [RFC PATCH v2 04/16] hw/net/xilinx_ethlite: Simplify by having configurable endianness

7 Nov 2024


      On 11/7/24 01:22, Philippe Mathieu-Daudé wrote:
...
+++ b/hw/microblaze/petalogix_s3adsp1800_mmu.c
@@ -121,9 +121,11 @@ petalogix_s3adsp1800_init(MachineState *machine)
      sysbus_connect_irq(SYS_BUS_DEVICE(dev), 0, irq[TIMER_IRQ]);
dev = qdev_new("xlnx.xps-ethernetlite");
+    qdev_prop_set_bit(dev, "little-endian", !TARGET_BIG_ENDIAN);
      qemu_configure_nic_device(dev, true, NULL);
      qdev_prop_set_uint32(dev, "tx-ping-pong", 0);
      qdev_prop_set_uint32(dev, "rx-ping-pong", 0);
+    qdev_prop_set_bit(dev, "little-endian-model", !TARGET_BIG_ENDIAN);
Surely only one of these.

r~

    

Richard Henderson