Re: [PATCH 2/5] tests: Remove storage pool/vol tests for sheepdog
On Mon, Aug 22, 2022 at 10:52:03 -0500, Jonathon Jongsma wrote:
On 8/22/22 9:48 AM, Peter Krempa wrote:
> The support for the sheepdog storage backend will be dropped in the
> upcoming patches. Remove all the relevant tests.
I happened to notice these the other day. Did you intend to keep them in?
$ git grep -l sheepdog -- tests/qemuxml2argvdata/*.xml
tests/qemuxml2argvdata/boot-dev+order.xml
tests/qemuxml2argvdata/boot-order.xml
tests/qemuxml2argvdata/disk-network-sheepdog.xml
These tests are for the qemu driver's instantiation of sheepdog backed
disks, which is orthogonal to libvirt's storage driver backend this
series is removing.
Specifically the sheepdog backend for disks was removed from qemu
starting with qemu-6.1. Minimum qemu supported by libvirt is qemu-4.2,
so there are releases which we support and thus it wouldn't be okay to
remove that support and by extension the tests for it.
Now for the individual test cases:
tests/qemuxml2argvdata/boot-dev+order.xml
tests/qemuxml2argvdata/boot-order.xml
I'll strip the sheepdog disk from these two and use DO_TEST_CAPS_LATEST
for them. Those tests are for configuring the boot order so a sheepdog
disk there is not really relevant to the main use case.
tests/qemuxml2argvdata/disk-network-sheepdog.xml
This is already using DO_TEST_CAPS_VER and is locked to qemu-6.0 due to
the above reason. This test can be removed once we bump minimum qemu to
6.1+.