A colleague asked about the status of this patch and it's availability in downstream openSUSE packages. I took a peek and LGTM. I then noticed Kristina has also reviewed the patch. I've added both R-B to the commit and pushed it.
I appreciate the review and push \o/ Should I have resubmitted with the R-B in the commit message after Kristina's review? Mailing list contribution process is still very unfamiliar to me.
This appears to be your first commit to the libvirt project. Congratulations! :-)
Thanks :-) On Tue, Apr 2, 2024 at 5:13 PM Jim Fehlig <jfehlig@suse.com> wrote:
On 3/26/24 13:38, brett.holman@canonical.com wrote:
From: Brett Holman <brett.holman@canonical.com>
Add DMI support for risc-v and mips. Attempt to read dmidecode and fall back to old behavior if that fails.
The SMBIOS specification[1] officially supports both RISC-V and LoongArch. Some mips-based Loongson-3 processors also have SMBIOS.
[1] https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.7.0.p...
Signed-off-by: Brett Holman <brett.holman@canonical.com>
Hi Brett,
A colleague asked about the status of this patch and it's availability in downstream openSUSE packages. I took a peek and LGTM. I then noticed Kristina has also reviewed the patch. I've added both R-B to the commit and pushed it.
This appears to be your first commit to the libvirt project. Congratulations! :-)
Regards, Jim
--- src/util/virsysinfo.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/src/util/virsysinfo.c b/src/util/virsysinfo.c index 4a03fc3246..0d9083c891 100644 --- a/src/util/virsysinfo.c +++ b/src/util/virsysinfo.c @@ -1249,6 +1249,8 @@ virSysinfoRead(void) (defined(__x86_64__) || \ defined(__i386__) || \ defined(__amd64__) || \ + defined(__riscv__) || \ + defined(__mips__) || \ defined(__loongarch__)) return virSysinfoReadDMI(); #else /* WIN32 || not supported arch */