On Tue, Sep 08, 2009 at 09:30:58AM +0200, Pritesh Kothari wrote:
Lastly added OOM checks in few places which were missed earlier.
Okay applied thanks ! I would concur with Chris, I think the current practice in most of libvirt code when there is a complex routine is to handle OOM with a goto to an error label.
Thanks Chris and Daniel for the review, i will change the function here as well as others where there are complex routines and make it like the other drivers in libvirt, will soon post a patch for same.
Okay, no rush, I think I would apply it after the release, i.e. next week anyway.
This allows to limit the level of cascading. This is stylistic, but affects readability, and hence maintainability :-)
stylistic, ha ha.
Err, yes :-) vim in 80 charecter wide windows makes the code harder to review, try it ;-) Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/