Quite a critical bit of the libvirt code is that which converts between
SEXPR and XML, and vica-verca. I've broken this code several times when
making changes, so it is way overdue to get some unit test coverage in
this area.
The attached patch adds such coverage - defining two tests xml2sexprtest
and sexpr2xmltest. The tests are pretty simple, in the tests/ directory
I just have a bunch of xml & sexpr files - one is the fixed input, the
other is the expected output. The test just runs the conversion and compares
the actual output with the expected output. Currently I've added two example
data files - one for paravirt & one for fully-virt. With this patch you
can run tests:
$ make check
make check-TESTS
make[1]: Entering directory `/home/berrange/src/xen/libvirt/tests'
XML-2-SEXPR PV config ... OK
XML-2-SEXPR FV config ... OK
PASS: xml2sexprtest
SEXPR-2-XML PV config ... OK
SEXPR-2-XML FV config ... OK
PASS: sexpr2xmltest
==================
All 2 tests passed
==================
make[1]: Leaving directory `/home/berrange/src/xen/libvirt/tests'
I'm shortly about to start on updating the code to deal with new CDROM
configuration format for HVM guests in Xen 3.0.3, and so intend to add
further test files during this process (and of course make sure I don't
break the existing ones :-)
Regards,
Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules:
http://search.cpan.org/~danberr/ -=|
|=- Projects:
http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|