Re: [libvirt] [PATCH 10/10] qemu: cgroup: Setup cgroups for bios/firmware images

On Tue, Feb 16, 2016 at 04:29:52PM +0100, Peter Krempa wrote: > oVirt wants to use OVMF images on top of lvm for their 'logical' > storage thus we should set up device ACLs for them so it will actually > work. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1305922 > --- > src/qemu/qemu_cgroup.c | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > @@ -573,6 +590,9 @@ qemuSetupDevicesCgroup(virQEMUDriverPtr driver, > goto cleanup; > } > > + if (qemuSetupFirmwareCgroup(vm) < 0) > + goto cleanup; > + if (vm->def->os.loader && ..

> for (i = 0; i < vm->def->ndisks; i++) { > if (qemuSetupDiskCgroup(vm, vm->def->disks[i]) < 0) > goto cleanup; ACK with the crash fixed.