Re: [libvirt] [PATCH v3] nwfilter: fix loadable module support

statstest links to libvirt_test.la which links to libvirt_driver.la so it will inherit the link to gnutls still. We should not need to add any libraries directly to libvirt_la_LIBADD, always to one of the other modules first. > diff --git a/src/Makefile.am b/src/Makefile.am > index 5109302..eb93727 100644 > --- a/src/Makefile.am > +++ b/src/Makefile.am > @@ -1001,10 +1002,10 @@ libvirt_la_LDFLAGS = > $(VERSION_SCRIPT_FLAGS)$(LIBVIRT_SYMBOL_FILE) \ > $(CYGWIN_EXTRA_LDFLAGS) $(MINGW_EXTRA_LDFLAGS) > libvirt_la_BUILT_LIBADD += ../gnulib/lib/libgnu.la > libvirt_la_LIBADD += $(LIBXML_LIBS) \ > - $(LIBPCAP_LIBS) $(LIBNL_LIBS) \ > + $(LIBPCAP_LIBS) $(LIBNL_LIBS) $(GNUTLS_LIBS) \ > These two previous additions of LIBPCAP and LIBNL are both wrong too. They should be linking to libvirt_driver_nwfilter.la instead.