Re: [PATCH] maint: fix "mixing declarations and code" errors
On Wed, Nov 09, 2022 at 10:26:57AM +0100, Michal Prívozník wrote:
On 11/9/22 09:15, Daniel P. Berrangé wrote:
> On Tue, Nov 08, 2022 at 08:35:31PM +0100, Roman Bogorodskiy wrote:
>> clang 14.0.5 complains:
>>
>> ../src/bhyve/bhyve_device.c:42:29: error: mixing declarations and code
>> is incompatible with standards before C99
>
> Err, we set std=gnu99 so it shouldn't be complaining about that.
But we also enable -Wdeclaration-after-statement which checks for the
same thing. I wonder how could gcc not identify these.
We don't build bhyve driver on Linux, and the FreeBSD build uses
clang IIRC.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|