On Wed, 2020-05-13 at 15:00 +0200, Jiri Denemark wrote:
On Wed, May 13, 2020 at 12:30:48 +0100, Daniel P. Berrangé wrote:
On Wed, May 13, 2020 at 01:19:35PM +0200, Andrea Bolognani wrote:
I completely agree, #nnn is too ambiguous to be useful.
The widespread usage by any other project using GitLab/GitHub proves otherwise and libvirt isn't special in this regard.
This just means that either everyone uses the reference only as a simple way of closing the associated issue or they use the web UI to look at commits.
Let's just hope they don't use the "wrong" Web UI, for example by looking at the GitHub mirror, because otherwise they might be sent to a completely wrong issue, as Peter just demonstrated.
We can have a simple prebuild check, similar to the one we already use for DCO checking, which catches uses of
Fixes #nnn
and similar and tells contributors to use a full URL instead.
This is needless extra work for contributors.
I guess I'm a bit strange, but to me pasting a complete link to an issue is (if I even know such issue exists, of course) less work than selecting just the number and prefixing it with '#'.
If that's the case, then at least know that you're not the only one who's strange around here :) -- Andrea Bolognani / Red Hat / Virtualization