Re: [libvirt] [PATCH 2/2] domain_conf: add "default" to list of valid spice channels
On Mon, May 07, 2012 at 09:53:05AM -0600, Eric Blake wrote:
On 05/07/2012 06:33 AM, Alon Levy wrote:
> qemu's behavior in this case is to change the spice server behavior to
> require secure connection to any channel not otherwise specified as
> being in plaintext mode. libvirt doesn't currently allow requesting this
> (via plaintext-channel=<channel name>).
>
> RHBZ: 819499
>
> Signed-off-by: Alon Levy <alevy(a)redhat.com>
> ---
> src/conf/domain_conf.c | 3 ++-
> src/conf/domain_conf.h | 1 +
> 2 files changed, 3 insertions(+), 1 deletion(-)
Same complaints as for 1/2 (docs, RNG schema, tests). Also, is it ever
valid to mark the default channel for plaintext (meaning all channels
not marked secure are plaintext), or must it only be permitted for
secure channels?
It's valid.
--
Eric Blake eblake(a)redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org