Re: [libvirt] [PATCH 15/30] storagefile: Fill in meta->externalDataStoreRaw
On 10/7/19 6:49 PM, Cole Robinson wrote:
Call qcow2GetExtensions to actually fill in the virStorageSource
externalDataStoreRaw member
Signed-off-by: Cole Robinson <crobinso(a)redhat.com>
---
Reviewed-by: Daniel Henrique Barboza <danielhb413(a)gmail.com>
src/util/virstoragefile.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
index 7e32d7619e..53fe4590b4 100644
--- a/src/util/virstoragefile.c
+++ b/src/util/virstoragefile.c
@@ -1060,6 +1060,12 @@ virStorageFileGetMetadataInternal(virStorageSourcePtr meta,
fileTypeInfo[meta->format].getFeatures(&meta->features,
meta->format, buf, len) < 0)
return -1;
+ VIR_FREE(meta->externalDataStoreRaw);
+ if (meta->format == VIR_STORAGE_FILE_QCOW2 &&
+ qcow2GetExtensions(buf, len, NULL, &meta->externalDataStoreRaw) < 0)
{
+ return -1;
+ }
+
VIR_FREE(meta->compat);
if (meta->format == VIR_STORAGE_FILE_QCOW2 && meta->features
&&
VIR_STRDUP(meta->compat, "1.1") < 0)