Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

On 25.06.2018 09:16, Peter Krempa wrote: > On Fri, Jun 22, 2018 at 14:55:02 +0200, Kevin Wolf wrote: >> Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: >>> >>> On 06/15/2018 04:21 PM, Kevin Wolf wrote: >>>> The -drive option serial was deprecated in QEMU 2.10. It's time to >>>> remove it. >>>> >>>> Tests need to be updated to set the serial number with -global instead >>>> of using the -drive option. [...] >>> So it seems that this breaks s390x. >> >> Thanks for bringing this up. libvirt should fix this before QEMU 3.0 is >> released. > > So, I already extracted the code that formats the attributes which > should be actually done for the frontend few months ago, but did not > swithc to it since I did not want to check when everything was added. > > The fix will be rather simple if we are certain that the disk serial, > geometry and error policies were supported in qemu 1.5. In that case we > can switch unconditionally to the new format. The CHS device properties are available since QEMU v1.2: - IDE: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=ba801960 - SCSI: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=d252df48 - virtio-blk: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=e63e7fde2 The "serial" property and the PCI "addr" property are also available since 2012 at least, I didn't fully track their origins, but QEMU v1.2 already supported them. So yes, all these properties should be available in QEMU 1.5 already.