-----Original Message----- From: Or Ozeri Sent: Sunday, 15 January 2023 13:41 To: Peter Krempa <pkrempa@redhat.com> Cc: libvir-list@redhat.com; Danny Harnik <DANNYH@il.ibm.com> Subject: RE: [EXTERNAL] Re: [PATCH v1 0/4] Introduce active disk internal snapshot support
Note that a few days ago Pavel pushed his series adding support for deletion of external snapshots. That code heavily depends on the fact that mixing internal/external snapshots was forbidden.
Thus the patch in this series will not be acceptable until you fix the code that Pavel added.
My code touches only snapshot creation. I see that for deletion, Pavel added a check which yields: "deletion of external and internal children disk snapshots not supported " So I don't think any change is required, unless you want to support a new feature of deletion of mixed snapshots.
I missed that this check is for snapshot children. But I guess a similar validation can be added to qemuSnapshotDeleteValidate, to ensure that user is not trying to delete a mixed snapshot.