Re: [PATCH V2 0/3] Add virDomainSetLaunchSecurityState API
On Fri, Dec 10, 2021 at 09:48:00AM +0100, Peter Krempa wrote:
On Thu, Dec 09, 2021 at 15:04:12 -0700, Jim Fehlig wrote:
> V2 of https://listman.redhat.com/archives/libvir-list/2021-November/msg00980.html
>
> Like V1, this series is compile-tested only. I plan to work on functional
> testing soon, after wrapping up some tasks.
I have 2 minor comments:
- virsh impl is missing and it's not justified why
virsh is missing for all the sev related commands, but I've just
addressed that in my series, so agree it makes sense to add in
this series too.
- 'qemuMonitorJSONSetLaunchSecurityState' is missing a test
case in
qemumonitorjsontest. A simple test with GEN_TEST_FUNC/DO_TEST_GEN is
enough, it validates the arguments against the QMP monitor schema.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|