Re: [libvirt] [PATCH] udev: Don't try to dump DMI on non-intel archs
On 07/19/2011 08:52 AM, Michal Privoznik wrote:
DMI is Intel& Intel-compatible specific. Don't try to dump
information
on non-compatible architectures, which results only in error message in
logs.
---
NB: libsmbios is exclusively for x86_64 ia64 %{ix86}
src/node_device/node_device_udev.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
ACK.
But do we also need to patch src/util/sysinfo.c, which makes callouts to
dmidecode(1)? That is, if libsmbios is arch-specific, then I imagine
that so is dmidecode, and do we gracefully handle dmidecode failures in
that case?
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org