Re: [libvirt] [PATCH] qemu driver: use lseek64 for setting position in logfile
On 01/04/2011 07:38 PM, Daniel Veillard wrote:
On Tue, Jan 04, 2011 at 09:46:07AM -0500, Stefan Berger wrote:
Looks fine to me, ACK
I checked it in earlier today with the lseek64's removed...
But the real problem is getting huge log files, there is a trade off
between the default log level and the amount of information we want
to have handy in case something goes wrong.
This was me activating a DEBUG-#define
in a Qemu driver and doing
suspend/resume tests for a couple of hours.
One of the thing I plan to implement is to change the default
behaviour
to log all message to an in-memory ring buffer, and in case of an error
at runtime log that buffer collecting the past recent detailed informations
of what happened before the current error. I assume this will have to
be tuned too to avoid excessive default logging, but this should improve
at least the usefulness of those logs,
I guess you would need to find some sort of
a trigger for the 'buffer
collecting'. The tests I ran just redirected everything fprintf'ed to
stdout/stderr by Qemu into that log file, which was good for this
purpose. Typically Qemu is pretty quiet.
Stefan
Daniel