Re: [libvirt] [PATCH 00/22] Python tweaks
On Mon, Mar 19, 2018 at 10:36:28AM +0000, Daniel P. Berrangé wrote:
On Sat, Mar 17, 2018 at 02:23:18PM +0000, Radostin Stoyanov wrote:
> These patches improve the code style of python code
> by applying some PEP8 recommendations and simplifying
> some functions.
How did you identify all the places that needed fixing ? I'm assuming you
were running via some automated tool. If so this series ought to ensure
that the tool is run as part of "make syntax-check", so that we don't
reintroduce the problems later.
Also, did you check whether the generated files are byte-for-byte identical
before & after applying this patch series, under both py2 & py3 ?
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|