Re: [libvirt] [PATCH] bhyve: don't leak tap devices on failures

On 30.03.2014 14:53, Roman Bogorodskiy wrote:

On failures, virBhyveProcessStart() does not cleanup network interfaces that could be created by virBhyveProcessBuildBhyveCmd(), which results in a leaked tap device.

To fix that, extract network cleanup code to bhyveNetCleanup() and use it in cleanup stage of virBhyveProcessStart(). --- src/bhyve/bhyve_process.c | 34 ++++++++++++++++++++++------------ 1 file changed, 22 insertions(+), 12 deletions(-)

ACK and worth pushing prior to the release. Michal