On Thu, May 09, 2013 at 03:20:54PM +0200, Michal Privoznik wrote:
On 09.05.2013 15:02, Daniel P. Berrange wrote:
From: "Daniel P. Berrange" <berrange@redhat.com>
The udev interface driver did not follow standard naming convention for goto labels.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com> --- src/interface/interface_backend_udev.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-)
Do we want to bother with udevConnectListAllInterfaces? The 'cleanup' label makes a tiny bit of sense although I'd vote for 'error'.
However, in: udevGetIfaceDefBond udevGetIfaceDefVlan udevGetIfaceDef
s/cleanup/error/ shall be made.
But this patch is good as-is. ACK if you reconsider extending this patch to functions I've pointed out.
I'll push a fix for those cases too. Separated return paths should always use 'error' rather than 'cleanup' Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|