Re: [libvirt] [PATCH V2 4/4] libxl: add support for rbd qdisk
On 02/22/2016 07:35 AM, Ján Tomko wrote:
On Wed, Feb 17, 2016 at 05:33:45PM -0700, Jim Fehlig wrote:
> xl/libxl already supports qemu's network-based block backends
> such as nbd and rbd. libvirt has supported configuring such
> <disk>s for long time too. This patch adds support for rbd
> disks in the libxl driver by generating a rbd device URL from
> the virDomainDiskDef object. The URL is passed to libxl via the
> pdev_path field of libxl_device_disk struct. libxl then passes
> the URL to qemu for cosumption by the rbd backend.
>
> Signed-off-by: Jim Fehlig <jfehlig(a)suse.com>
> ---
> src/libxl/libxl_conf.c | 192 ++++++++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 191 insertions(+), 1 deletion(-)
>
ACK with the whitespace fix.
Hi Jan,
Sorry I missed your comments before pushing this series. I'll address them in a
follow-up. Thanks for your time reviewing these changes!
Regards,
Jim