On Mon, Dec 05, 2011 at 12:15:29PM -0700, Eric Blake wrote:
Over time, Fedora and RHEL RPMs have often backported upstream patches that touched configure.ac and/or Makefile.am; this necessitates rerunning the autotools for the patch to be effective. Making this part of the spec file will make it easier for future backports to pull patches without thinking about this issue. However, there have been historical instances where an update in the autotools caused FTBFS situations; make it easy to avoid these by allowing the user to override our default.
* libvirt.spec.in (BuildRequires): Add autotools. (%build): Conditionally use them before configure. ---
v2: make the autotools default overridable, so that an rpm packager can bypass any changes caused by incompatibilities in an autotools upgrade.
libvirt.spec.in | 13 +++++++++++++ 1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in index 97b811d..806ff8f 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -8,6 +8,11 @@ sed -ne 's/^\.fc\?\([0-9]\+\).*/%%define fedora \1/p')} %endif
+# Default to running autoreconf in case any downstream patches touched +# configure.ac or Makefile.am. Set enable_autotools to 0 if you want +# to skip this step, perhaps if an upgrade in the autotools causes problems. +%{?enable_autotools:%define enable_autotools 1}
No, we should default to *not* running autotools - it just introduces a new failure point for no benefit in 99% of the time where we have no patches touching makefiles/configure. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|