Re: [libvirt-jenkins-ci PATCH v2 5/6] guests: Introduce the new 'gitlab' flavor
On Tue, 2020-04-07 at 13:31 +0200, Erik Skultety wrote:
+- name: Register the gitlab-runner agent
+ become: true
+ become_user: gitlab
+ shell: '/home/gitlab/bin/gitlab-runner register --non-interactive --config {{
gitlab_runner_config_path }} --registration-token {{ gitlab_runner_secret }} --url {{
gitlab_url }} --executor shell --tag-list {{ inventory_hostname }}'
You didn't answer in the other thread, so I'll ask again here: is the
idea that we're going to use only the FreeBSD runners to supplement
the shared runners for the existing unit tests, and all Linux runners
are only going to be used for integration tests later on, hence why
we need to use the shell executor rather than the docker executor?
Additional nit: instead of using {{ inventory_hostname }} as tag, we
can have a nicer tag by using {{ os_name|lower }}-{{ os_version }}.
It would also be a good idea to quote all command arguments.
The rest looks good, but given the potential security issue raised by
Dan I'll wait for v3 before handing out actual ACKs :)
--
Andrea Bolognani / Red Hat / Virtualization