Re: [libvirt] [PATCH] Make QEMU driver use -chardev everywhere when it's available

> diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c > index c807688..4f4b3db 100644 > --- a/src/qemu/qemu_conf.c > +++ b/src/qemu/qemu_conf.c > @@ -1844,12 +1844,36 @@ int qemudBuildCommandLine(virConnectPtr conn, > if (monitor_chr) { > virBuffer buf = VIR_BUFFER_INITIALIZER; > > - qemudBuildCommandLineChrDevStr(monitor_chr,&buf); > - if (virBufferError(&buf)) > - goto error; > + /* Use -chardev if it's available */ > + if (qemuCmdFlags& QEMUD_CMD_FLAG_CHARDEV) { > + char id[16]; > + > + if (snprintf(id, sizeof(id), "monitor%i", i)> sizeof(id)) > + goto error; This is using 'i' uninitialized I believe. Its a little overkill to do a printf here at all since there's only ever a single monitor called 'monitor0'