Re: [libvirt] [python PATCH 1/2] qemu: support arbitrary monitor events

On 05.02.2014 03:01, Eric Blake wrote: > Wrap the new virConnectDomainQemuMonitorEventRegister function > being added in libvirt 1.2.2. This patch copies heavily from > network events (commit 6ea5be0) and from event loop callbacks > in libvirt-override.c, since in the libvirt_qemu module, we > must expose top-level functions rather than class members. >

> + LIBVIRT_ENSURE_THREAD_STATE; > + > + pyobj_cb = > libvirt_qemu_lookupPythonFunc("_dispatchQemuMonitorEventCallback"); > + if (!pyobj_cb) { > + goto cleanup; > + } > + > + dictKey = libvirt_constcharPtrWrap("conn"); > + if (!dictKey) > + return;

> + pyobj_conn = PyDict_GetItem(pyobj_cbData, dictKey); > + Py_DECREF(dictKey); > + > + /* Create a python instance of this virDomainPtr */ > + virDomainRef(dom); 1: ^^^ > + pyobj_dom = libvirt_virDomainPtrWrap(dom); > + Py_INCREF(pyobj_cbData); > + > + /* Call the Callback Dispatcher */ > + pyobj_ret = PyObject_CallFunction(pyobj_cb, > + (char *)"OOsLIsO", > + pyobj_conn, pyobj_dom, event, > seconds, > + micros, details, pyobj_cbData); > + > + Py_DECREF(pyobj_cbData); > + Py_DECREF(pyobj_dom); I'd expect counterpart of [1] here.