"Daniel P. Berrange" <berrange@redhat.com> wrote:
On Thu, Nov 29, 2007 at 07:15:49PM +0100, Jim Meyering wrote:
"Daniel P. Berrange" <berrange@redhat.com> wrote:
On Thu, Nov 29, 2007 at 05:21:30PM +0000, Daniel P. Berrange wrote:
Testing with valgrind found a number of memory leaks in all sorts of places in the drivers and virsh.
In case it is of use, attached is a valgrind suppressions file I used on Fedora 8 to hide the false positives it reports.
Great! I'd use it, too. Want to check it in?
I was wondering about whether we should or not. I wasn't sure how portable the supression defintiions are. Different OS will have different calltraces for each of these.
Yes, they'll be different elsewhere. Some will even be different if you merely change libraries. If someone cares enough to run valgrind on a system for which they need new suppressions, they can append to the file.