On Mon, Apr 19, 2021 at 8:56 PM Michal Privoznik <mprivozn@redhat.com> wrote:
On 3/30/21 8:36 AM, Han Han wrote:
>
> Han Han (3):
>    tests: negative test for hugepages with anonymous memory backing
>    tests: negative test for hugepages with ondemand mode
>    tests: negative test of binding memnode cellid to an nonexist guest
>      cell
>
>   .../qemuxml2argvdata/hugepages-anonymous.err  |  1 +
>   .../qemuxml2argvdata/hugepages-anonymous.xml  | 25 +++++++++++++++
>   tests/qemuxml2argvdata/hugepages-ondemand.err |  1 +
>   tests/qemuxml2argvdata/hugepages-ondemand.xml | 25 +++++++++++++++
>   ...une-memnode-cellid-nonexist-guest-cell.err |  1 +
>   ...une-memnode-cellid-nonexist-guest-cell.xml | 31 +++++++++++++++++++
>   tests/qemuxml2argvtest.c                      |  3 ++
>   7 files changed, 87 insertions(+)
>   create mode 100644 tests/qemuxml2argvdata/hugepages-anonymous.err
>   create mode 100644 tests/qemuxml2argvdata/hugepages-anonymous.xml
>   create mode 100644 tests/qemuxml2argvdata/hugepages-ondemand.err
>   create mode 100644 tests/qemuxml2argvdata/hugepages-ondemand.xml
>   create mode 100644 tests/qemuxml2argvdata/numatune-memnode-cellid-nonexist-guest-cell.err
>   create mode 100644 tests/qemuxml2argvdata/numatune-memnode-cellid-nonexist-guest-cell.xml
>

Han,

what's the story behind these? I'm not particularly fan of testing that
something does not work. Did we have regression in this area lately?
No regression lately. I only intended to cover some negative cases in unit tests.

Michal