Re: [libvirt] [PATCH 3/3] Use virBufferEscapeShell in virNetSocketNewConnectSSH

On Wed, Oct 12, 2011 at 05:22:02PM -0600, Eric Blake wrote: > On 10/12/2011 04:40 PM, Guido Günther wrote: >> to escape the netcat command since it's passed to the shell. Adjust >> expected test case output accordingly. >> --- > > Rebase this on top of my comments for 1/3 (no long lines). Also, > add one more test where $NC is something that actually proves things > work with shell meta-characters, perhaps by passing 'nc -4' as the > value that eventually supplies the %s for $NC, so that .expectOut > will include: sh -c 'if ''nc -4'' -q 2>&1 .... Done too.