Re: [libvirt] [PATCH go-xml] qemu: extend serial console source
On Mon, Oct 02, 2017 at 11:34:18AM +0000, Jeroen Simonetti wrote:
October 2 2017 12:47 PM, "Daniel P. Berrange"
<berrange(a)redhat.com> wrote:
>> This will change the type of `DomainSerial.Source` from
>> `*DomainChardevSource` to a new `*DomainSerialSource`.
>>
>> This is done to add support for networked serial ports and
>> keep the original DomainChardevSource unchanged.
>
> I'm not sure I see the point of this. Any chardev backed device type
> (parallel, serial, vmchannel) should be allowed to use network
> backends - there's no restriction that says its only for serial
> ports.
>
I was not aware that all chardev backed devices should be able to use network backend.
Does this mean I can simple extend the DomainChardevSource, add the required options
and there will be no naming conflict?
If so, this would mean there is no need for a breaking change.
If you would be so kind to confirm the above, I will send in a new patch with the
additional fields.
Yes, just add extra fields to the DomainChardevSource
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|