Re: [libvirt] [PATCH v2] use STRNEQ instead of !STREQ and new syntax-check rule to avoid !STREQ and !STRNEQ

used STRNEQ instead of !STREQ to remove inconsistency and intoduced new syntax-check rule for !STREQ and !STRNEQ so that we don't end up in the same situation again. Signed-off-by: Ishmanpreet Kaur Khera <khera.ishman(a)gmail.com&gt; --- cfg.mk | 18 ++++++++++++++++++ src/bhyve/bhyve_driver.c | 2 +- src/conf/network_conf.c | 4 ++-- src/conf/nwfilter_conf.c | 2 +- src/conf/nwfilter_params.c | 2 +- src/conf/storage_conf.c | 2 +- src/lxc/lxc_fuse.c | 4 ++-- src/openvz/openvz_driver.c | 2 +- src/qemu/qemu_command.c | 6 +++--- src/qemu/qemu_domain.c | 2 +- src/qemu/qemu_hotplug.c | 2 +- src/security/security_manager.c | 2 +- src/security/security_selinux.c | 12 ++++++------ src/storage/storage_backend_logical.c | 2 +- src/util/virfile.c | 2 +- src/util/virsystemd.c | 2 +- src/vz/vz_driver.c | 2 +- src/vz/vz_sdk.c | 2 +- src/xen/xend_internal.c | 2 +- src/xenconfig/xen_sxpr.c | 2 +- tests/commandtest.c | 10 +++++----- tests/securityselinuxlabeltest.c | 2 +- tests/virauthconfigtest.c | 2 +- tests/virbitmaptest.c | 12 ++++++------ tests/vircgrouptest.c | 2 +- tests/virkeyfiletest.c | 8 ++++---- tests/virnetsockettest.c | 2 +- tests/virtypedparamtest.c | 2 +- tests/viruritest.c | 16 ++++++++-------- 29 files changed, 74 insertions(+), 56 deletions(-) diff --git a/cfg.mk b/cfg.mk index e436434..7343dfc 100644 --- a/cfg.mk +++ b/cfg.mk @@ -1011,6 +1011,18 @@ sc_prohibit_pthread_create: halt="avoid using 'pthread_create', use 'virThreadCreate' instead" \ $(_sc_search_regexp) +sc_prohibit_not_streq: + @prohibit='!STREQ' \ + exclude='exempt from syntax-check' \ + halt='Use STRNEQ instead of !STREQ' \ + $(_sc_search_regexp) + +sc_prohibit_not_strneq: + @prohibit='!STRNEQ' \ + exclude='exempt from syntax-check' \ + halt='Use STREQ instead of !STRNEQ' \ + $(_sc_search_regexp) +