On Fri, Mar 18, 2011 at 09:28:08AM -0600, Eric Blake wrote:
The ref count was assigned to 1 at creation, then never modified again until it was decremented just before freeing the object.
* src/conf/domain_conf.h (_virDomainSnapshotObj): Delete unused field. (virDomainSnapshotObjUnref): Delete unused prototype. * src/libvirt_private.syms: Likewise. * src/conf/domain_conf.c (virDomainSnapshotObjNew) (virDomainSnapshotObjListDataFree): Update users. (virDomainSnapshotObjUnref): Delete. ---
I was about to add ATTRIBUTE_RETURN_CHECK to all Unref methods, when I discovered that this method is (currently) worthless.
If we ever change things in the future to have multiple threads referring to snapshot objects and need a reference counter, we can use Wen's proposed new base-class object to do that in a saner manner. In the meantime, let's just delete the bloat.
src/conf/domain_conf.c | 15 +-------------- src/conf/domain_conf.h | 3 --- src/libvirt_private.syms | 1 - 3 files changed, 1 insertions(+), 18 deletions(-)
ACK Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|