Re: [libvirt] [PATCH 14/14] Don't mark suspend as active until we know it is running

On 11/29/2011 08:44 AM, Daniel P. Berrange wrote:

From: "Daniel P. Berrange" <berrange@redhat.com>

If suspend failed for some reason (eg too short duration) then

s/eg/e.g./

susquent attempts to trigger suspend were rejected because we

s/susquent/subsequent/

had already marked a suspend as being in progress

* src/util/virnodesuspend.c: Don't mark suspend as active until we've successfully triggered it --- src/util/virnodesuspend.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

ACK. As long as we only mark aboutToSuspend while holding the lock, and only ever probe it while also holding the lock, then we're safe. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org