On Mon, 2019-05-06 at 10:01 +0200, Michal Privoznik wrote: [...]
+++ b/configure.ac @@ -925,6 +925,7 @@ AC_CONFIG_FILES([\ include/libvirt/libvirt-common.h \ examples/Makefile \ tests/Makefile \ + tests/tools/Makefile \
Are we sure we want to have a tests/tools/Makefile.am rather than a tests/tools/Makefile.inc.am that we include from tests/Makefile.am here? We seem to be going in the former direction, though I'm not actually sure what the trade-offs are. CC'ing Dan who introduced the Makefile.inc.am files in the first place. [...]
+++ b/tests/Makefile.am EXTRA_DIST += \ - check-file-access.pl \ - file_access_whitelist.txt + tools/check-file-access.pl \ + tools/file_access_whitelist.txt
These should go into the new Makefile(.inc).am, just like you've done with .valgrind.supp and oomtrace.pl. Everything else looks sane from a very cursory looks, but I'd like to put it through its paces ('make distcheck', 'make rpm', ...) before ACKing it. -- Andrea Bolognani / Red Hat / Virtualization