Re: [libvirt] [PATCH v2 32/37] Adapt to VIR_STRDUP in src/xenxs/*

On 04/29/2013 09:50 AM, Michal Privoznik wrote:

--- src/xenxs/xen_sxpr.c | 107 +++++++++++++++++++++------------------------------ src/xenxs/xen_xm.c | 43 ++++++++++----------- 2 files changed, 65 insertions(+), 85 deletions(-)

diff --git a/src/xenxs/xen_sxpr.c b/src/xenxs/xen_sxpr.c index 9a76d04..7ebaa30 100644 --- a/src/xenxs/xen_sxpr.c +++ b/src/xenxs/xen_sxpr.c

...

@@ -572,25 +560,21 @@ xenParseSxprNets(virDomainDefPtr def, net->type = VIR_DOMAIN_NET_TYPE_BRIDGE; /* XXX virtual network reverse resolve */

- if (tmp && - !(net->data.bridge.brname = strdup(tmp))) + if (tmp &&VIR_STRDUP(net->data.bridge.brname, tmp) < 0)

spacing ^^^^ ...