Re: [libvirt] [PATCH v2] Fix potential NULL dereference in remoteDomainMigratePrepare2

...

--- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -2849,17 +2849,34 @@ remoteDomainMigratePrepare2 (virConnectPtr dconn, goto done;

if (ret.cookie.cookie_len > 0) { + if (!cookie || !cookielen) { + remoteError(VIR_ERR_INTERNAL_ERROR, "%s", + _("caller ignores cookie or cookielen")); + goto error; + } ...

ACK; looks nicer than v1 for diagnosing a logic bug in the caller, rather than papering over it.

Thanks, pushed. Jirka