Re: [libvirt] [PATCH] qemu: don't fail on destroy if domain is inactive

Mgmt can not track if domain is already inactive before calling destroy because domain can become inactive because of crash/shutdown from guest. Thus it is make sense to

report success in this case. Another option is to return special error code but this is a bit more complicated. Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy(a)virtuozzo.com&gt; --- src/qemu/qemu_driver.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 62d8d97..0789efc 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -2172,8 +2172,10 @@ qemuDomainDestroyFlags(virDomainPtr dom, if (virDomainDestroyFlagsEnsureACL(dom->conn, vm->def) < 0) goto cleanup; - if (virDomainObjCheckActive(vm) < 0) + if (!virDomainObjIsActive(vm)) { + ret = 0; goto cleanup; + }