Re: [libvirt] [PATCH 2/2] capabilities: Add total number of cores and threads to the XML
On Tue, Jan 15, 2013 at 03:45:24PM +0100, Peter Krempa wrote:
Management applications may want to limit the maximum number of
vCPUs
the guest has assigned based on the number of physical cores in the
system (excluding threads) for performance reasons.
This patch adds output of the total number of cores and total number of
threads present in the system as this information couldn't be reliably
determined in all cases by the data provided by libvirt.
The new output looks like this on a system with HyperThreading:
<capabilities>
<host>
<cpu>
<arch>x86_64</arch>
<model>SandyBridge</model>
<vendor>Intel</vendor>
<topology sockets='1' cores='2' threads='2'
totalcores='2' totalthreads='4'/>
NACK, we should not be adding this data here - it is duplicating info
better provide in the NUMA <topology> hierarchy. Please explain why
this is not already sufficient ?
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|