Re: [libvirt PATCH v2 16/20] commandhelper: Use automatic memory management in parseArguments
On Tue, 2021-02-02 at 14:59 +0100, Peter Krempa wrote:
On Mon, Feb 01, 2021 at 12:28:00 +0100, Tim Wiederhake wrote:
> Signed-off-by: Tim Wiederhake <twiederh(a)redhat.com>
> ---
> tests/commandhelper.c | 42 ++++++++++++++++++++++-----------------
> ---
> 1 file changed, 22 insertions(+), 20 deletions(-)
>
> diff --git a/tests/commandhelper.c b/tests/commandhelper.c
> index 9f0b7f25ac..19dfc09151 100644
> --- a/tests/commandhelper.c
> +++ b/tests/commandhelper.c
> @@ -24,7 +24,9 @@
> #include <fcntl.h>
> #include <sys/stat.h>
>
> -#define VIR_NO_GLIB_STDIO /* This file intentionally does not link
> to libvirt/glib */
> +/* This file intentionally does not link to libvirt/glib */
> +#define VIR_NO_GLIB_STDIO
Spurious line break.
Intentional. The comment now refers to not only the "#define
VIR_NO_GLIB_STDIO" but also serves as a justification for the custom
cleanup macro that otherwise should be replaced by some glib g_*
construct.