(answering for Peter since he is on "vacation", so it may be awhile before he gets around to this)

On 12/14/20 5:54 PM, Ryan Gahagan wrote:

On Fri, Dec 11, 2020 at 3:35 AM Peter Krempa <pkrempa@redhat.com> wrote:

In subject/summary. We don't have anything which we'd prefix with
'compatibilities:'.

Just to confirm, does this mean that we should not implement the feedback Han Han suggested about the NFS capability flags and instead leave the commit as-is (except for the summary)?

Yes. What Han Han was discussing is the QEMU capabilities flags, which indicate which of a large set of features are supported by a particular QEMU binary. Since, as you say below, any QEMU binary that is capable of using blockdev is by definition capable of using NFS, there is no need to add an extra flag for NFS.

We didn't provide an NFS CAPS flag because in a previous email you had suggested:
"- there's no need to add a specific capability for the NFS protocol as
it predates libvirt's use of -blockdev (QEMU_CAPS_BLOCKDEV). You have to add a check for it to qemuDomainValidateStorageSource based on the above capabapility."

We will provide this check in qemuDomainValidateStorageSource, but do we need to worry about CAPS flags?