Re: [libvirt] [PATCH v2 2/2] virsh: Don't reconnect after the command when disconnected

On Mon, Dec 01, 2014 at 12:00:53 +0100, Martin Kletzander wrote: > Each command that needs a connection causes a new connection to be > made. Reconnecting after a command failed is pointless, mainly when > there is no other command to run. Removeing three lines of code takes > care of that and keeps virsh working as it should. > > Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com&gt; > --- > tools/virsh.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/tools/virsh.c b/tools/virsh.c > index bcfa561..0ead9ae 100644 > --- a/tools/virsh.c > +++ b/tools/virsh.c > @@ -1958,9 +1958,6 @@ vshCommandRun(vshControl *ctl, const vshCmd *cmd) > if (!ret) > vshReportError(ctl); > > - if (!ret && disconnected != 0) > - vshReconnect(ctl); > - > if (STREQ(cmd->def->name, "quit") || > STREQ(cmd->def->name, "exit")) /* hack ... */ > return ret; ACK