On Wed, Mar 27, 2019 at 05:10:44AM -0500, Eric Blake wrote:
The remote code generator had to be taught about the new
virDomainCheckpointPtr type, and about the capitalization of
virDomainSnapshotCreateXML2(), at which point the remote driver code
for backups can be generated.
Signed-off-by: Eric Blake <eblake(a)redhat.com>
---
src/remote/remote_daemon_dispatch.c | 22 ++-
src/remote/remote_driver.c | 34 +++-
src/remote/remote_protocol.x | 259 +++++++++++++++++++++++++++-
src/remote_protocol-structs | 139 +++++++++++++++
src/rpc/gendispatch.pl | 34 ++--
5 files changed, 468 insertions(+), 20 deletions(-)
+struct remote_domain_backup_begin_args {
+ remote_nonnull_domain dom;
+ remote_string disk_xml;
+ remote_string checkpoint_xml;
+ unsigned int flags;
+};
+
+struct remote_domain_backup_begin_ret {
+ int result;
Feels like this should be 'id', since IIUC it is returning a job
ID.
+};
+
+struct remote_domain_backup_get_xml_desc_args {
+ remote_nonnull_domain dom;
+ int id;
+ unsigned int flags;
+};
+
+struct remote_domain_backup_get_xml_desc_ret {
+ remote_nonnull_string xml;
+};
+
+struct remote_domain_backup_end_args {
+ remote_nonnull_domain dom;
+ int id;
+ unsigned int flags;
+};
+
+struct remote_domain_backup_end_ret {
+ int retcode;
+};
With that one rename above
Reviewed-by: Daniel P. Berrangé <berrange(a)redhat.com>
Regards,
Daniel
--
|:
https://berrange.com -o-
https://www.flickr.com/photos/dberrange :|
|:
https://libvirt.org -o-
https://fstop138.berrange.com :|
|:
https://entangle-photo.org -o-
https://www.instagram.com/dberrange :|