On 07/30/2010 12:20 PM, Matthias Bolte wrote:
> @@ -75,7 +73,7 @@
virStorageBackendProbeTarget(virStorageVolTargetPtr target,
> allocation,
> capacity)) < 0) {
> close(fd);
> - return -1;
> + return ret;
Why do you return ret here? Doing so doesn't harm but it's not
necessary, virStorageBackendUpdateVolTargetInfoFD returns 0 or -1
only, in contrast to virStorageBackendVolOpenCheckMode that can return
0, -1 or -2.
The alternative was to delete the dead assignment to ret, since we would
be returning -1 ourselves.
ACK.
Thanks; pushed.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library
http://libvirt.org