Re: [libvirt] [PATCH 0/3] add pci-bridge device and address type

>> >> No, even it's not supported now, the proposed XML should be >> designed compatible enough for future. Note that as long >> as a new XML is added, it can't changed/removed for back-compact, >> so when introducing new XMLs, you should consider the future. >> >> And on other hand, the introduced XML should be general >> enough for all drivers, not only QEMU. >> >> Anyway, regardless of the current qemu implementation, I think >> you should refer to the specification of PCI SGI, so that the >> proposed XML could be compatible enough for the future. > > yes, I will, but any problem with the pci-bridge definition in XML? > it's just a simple element. > can you tell more details about problem of this new definition? The point is how to known the pci device is attached to which pci bridge *if* multiple bridge is supported. I don't think the two types ("root" and "subordinate") could do the work.

> >> >>> every subordinate will attach to root bridge, and has its own slot. >>> >>>> >>>> To describe the relationship between bridges, perhaps we will need >>>> "parent" and "child" properties for<pcibridge> device. >>>> >>>> To describe the relatioship between a pci device and a pci bridge, >>>> a property like "bridge" for general pci device should be enough. >>>> In this case, another property for<pcibridge> is needed, to >>>> indentify it, such as "id" or "name". >>> >>> only relationship is not enough, it's unsuitable for passing '-device >>> pci-bridge' to qemu, so I define a new device and address type for >>> pci-bridge in libvirt. >>> >>>> >>>> Regards, >>>> Osier >>>> >>>> >>> >> >