Re: [libvirt] [RFC 05/12] USB devices gain a new USB address child element
On Sun, Aug 21, 2011 at 10:01:16PM +0300, Marc-André Lureau wrote:
---
docs/schemas/domain.rng | 14 +++++
src/conf/domain_conf.c | 62 +++++++++++++++++++-
src/conf/domain_conf.h | 10 +++
src/qemu/qemu_command.c | 40 ++++++++++---
src/qemu/qemu_command.h | 6 +-
src/qemu/qemu_hotplug.c | 2 +-
.../qemuxml2argv-input-usbmouse-addr.args | 1 +
.../qemuxml2argv-input-usbmouse-addr.xml | 27 +++++++++
tests/qemuxml2argvtest.c | 2 +
9 files changed, 149 insertions(+), 15 deletions(-)
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-input-usbmouse-addr.args
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-input-usbmouse-addr.xml
So this lets users specify an explicit USB address for their devices.
If an existing app is using libvirt though, they won't be doing this,
and we want to make sure they get stable USB port addresses. With PCI
we have a function in the QEMU driver which will assign PCI slots to
any PCI device which doesn't already have one. I think we need todo
the same for USB ports, so all configs become migration-safe.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|