Re: [libvirt] [PATCH 3/3] esx: Add volume upload and download to the storage driver

On 07/02/2012 03:44 PM, Matthias Bolte wrote: These flags would also be useful for other drivers; I've complained in the past that qcow2 images under the qemu driver should be able to differentiate between metadata (let download give me the qcow2 headers) and content (return the data as seen by the guest, effectively converting from qcow2 to raw in the download). Before we can accept the new flags, we need to also document their effect on the functions in src/libvirt.c. I'd suggest splitting this commit into two parts - add the new flags and expose them in virsh in part 1, then implement the flags for esx in part 2. This matters in case someone else implements the flags for qemu, then wants to backport the new flags and the qemu implementation but not the esx implementation. Also, needs documentation in tools/virsh.pod for the new options in virsh.c. I'm not sure whether it makes sense to define a name for '0'; in some cases we have done it, in others we have not. I'm not opposed to the idea, but we aren't very consistent. I do, however, like the idea of using the flags argument to support the needs of ESX in representing things through two files. I have not closely reviewed this patch for content, so much as offering this as my first impressions high-level review. s/Non/None/ I think consensus was that the next version will be numberd 0.10.0, thanks to the addition of the parallels driver. -- Eric Blake eblake(a)redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org