On Fri, May 20, 2022 at 05:49:53PM -0300, Daniel Henrique Barboza wrote:
On 5/19/22 04:44, Andrea Bolognani wrote:
On Tue, May 17, 2022 at 05:32:56PM -0300, Daniel Henrique Barboza wrote:
On 5/12/22 04:52, Andrea Bolognani wrote:
Don't forget to add the new test case to qemuxml2xmltest too.
It would be great if, as a follow-up, you could look into converting these test cases to the DO_TEST_CAPS_ARCH_LATEST_* macros, which would allow us to drop the hardcoded list of capabilities.
Right. Guess I'll use ARCH_LATEST in the tests I'm adding in this patch as well.
Yeah, that'd be fantastic :)
I had to make adjustments (add a new ARG_CAPS_HOST_CPU_MODEL arg) to allow these conversions for tests that requires a specific cpu model to work and with arch_latest.
Just sent some patches. If we get them first then I can also use arch_latest in the new P10 tests as well.
I see Martin has already taken care of reviewing those patches, so you should be able to post a rebased version of the POWER10 support now, right? Freeze starts tomorrow, so we can still get that merged in time for the next release if we're quick. -- Andrea Bolognani / Red Hat / Virtualization