Re: [libvirt] [PATCH] Bugfix for building with no-git-option

On 02/04/2015 05:49 AM, Stefan Zimmermann wrote: s/inforamtion/information/ Reads awkwardly. Better would be: maint: improve usage of autogen's --no-git autogen.sh supports a --no-git mode that avoids the need to use git; but to date, it only worked if GNULIB_SRCDIR is set in the environment. However, the bootstrap script also works if it is passed a --gnulib-srcdir command line argument; add support for that in autogen.sh. NACK. This assumes that the caller supplies --gnulib-srcdir as the second argument, immediately after --no-git. But this is not required; in fact, it is possible to set GNULIB_SRCDIR in the environment and not even pass --gnulib-srcdir on the command line. Also, 'shift 2' is not portable to older /bin/sh. A better fix would be appending to $no_git only after checking if the next argument(s) after --no-git really specify a gnulib srcdir. But the idea of your patch makes sense. Would you like to try your hand at v2? Maybe something like: no_git= if test "x$1" = "x--no-git"; then no_git=" $1" shift case "$1 $2" in --gnulib-srcdir=*) no_git="$no_git $1"; shift ;; --gnulib-srcdir *) no_git="$no_git $1 $2"; shift; shift ;; esac -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org