Re: Improve default machine type selection
On Fri, Apr 14, 2023 at 03:33:21PM +0200, Peter Krempa wrote:
On Fri, Apr 14, 2023 at 06:26:02 -0700, Andrea Bolognani wrote:
> I don't think we rely on default machine types anywhere in the test
> suite, and even if we were only minor touch-ups would probably be
> necessary.
The test suite does use/validate/assign machine types, but I've already
removed the all of the fake-machine type infrastructure for RISC-V so
you only get to use the qemuCapabilities object populated from what we
have in tests/qemucapabilitiesdata/.
There doesn't seem to be any qemuxml2argv test case referencing 'spike'
so obviously the default machine is not covered by tests. That also
means that the test suite will not break :)
Yeah, exactly: for all existing test cases we pick the machine type
explicitly, so changing the default shouldn't affect them at all.
And the fact that we don't have test cases covering integratorcp or
spike is not unexpected, since for both Arm and RISC-V we've only
ever really considered the virt machine type.
--
Andrea Bolognani / Red Hat / Virtualization